From f47bcb5cbccbb93f4cf6a892c8b58f92efc4352f Mon Sep 17 00:00:00 2001 From: Kp Date: Wed, 19 Oct 2022 01:17:33 +0000 Subject: [PATCH] Fix buffer overread at startup Commit 5b7fb9c4025c incorrectly removed the trailing null from `g_descent_version`. Add an explicit null, since list initialization does not imply a null. Fixes: 5b7fb9c4025c626453c48d7d67a4afffad1d8599 ("Reduce use of quotes for passing vers_id defines") --- similar/main/vers_id.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/similar/main/vers_id.cpp b/similar/main/vers_id.cpp index bc3ed1a43..5cbeb8bfa 100644 --- a/similar/main/vers_id.cpp +++ b/similar/main/vers_id.cpp @@ -24,7 +24,7 @@ #endif // "D1X-Rebirth " or "D2X-Rebirth " -constexpr char g_descent_version[] = {'D', DXX_NAME_NUMBER, 'X', '-', 'R', 'e', 'b', 'i', 'r', 't', 'h', ' ', DESCENT_VERSION_EXTRA}; +constexpr char g_descent_version[]{'D', DXX_NAME_NUMBER, 'X', '-', 'R', 'e', 'b', 'i', 'r', 't', 'h', ' ', DESCENT_VERSION_EXTRA, 0}; constexpr char g_descent_build_datetime[21] = DXX_VERSID_BUILD_DATE " " DXX_VERSID_BUILD_TIME; #ifdef DXX_RBE