TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix bogus optimization in robot maker paging

Browse source 
The optimization meant to skip materialization centers which had no
robots enabled, but had two bugs.  It tested for a NULL address instead
of inspecting the bits in robot_flags[0], which caused the test to
always succeed.  It also ignored robot_flags[1], so a materialization
center with only high end robots would be wrongly skipped.

Remove the test, since the loop is cheap and handles all cases
correctly.
This commit is contained in:
Kp 2013-03-23 21:20:41 +00:00
parent 1eac5d4f37
commit bbd182b113
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
main/paging.c
View file

@ -272,7 +272,6 @@ void paging_touch_robot_maker( segment * segp )
if ( seg2p->special == SEGMENT_IS_ROBOTMAKER ) {
paging_touch_vclip(&Vclip[VCLIP_MORPHING_ROBOT]);
if (RobotCenters[seg2p->matcen_num].robot_flags != 0) {
int i;
uint flags;
int robot_index;
@ -289,7 +288,6 @@ void paging_touch_robot_maker( segment * segp )
robot_index++;
}
}
}
}
}