Fix potential memory leak in grs_main_bitmap move-assignment

2019-02-02 18:36:39 +00:00 · 2019-02-02 18:36:39 +00:00 · ba442b99bd
parent 8dcf4f99e0
commit ba442b99bd
1 changed files with 5 additions and 2 deletions
--- a/common/include/gr.h
+++ b/common/include/gr.h
@ -261,10 +261,13 @@ public:
 	}
 	grs_main_bitmap &operator=(grs_main_bitmap &&r)
 	{
+		if (this == &r)
+			return *this;
+		reset();
 		grs_bitmap::operator=(std::move(static_cast<grs_bitmap &>(r)));
-		bm_data = exchange(r.bm_data, nullptr);
+		r.bm_data = nullptr;
 #if DXX_USE_OGL
-		gltexture = exchange(r.gltexture, nullptr);
+		r.gltexture = nullptr;
 #endif
 		return *this;
 	}