From ad806a8251336bbb86452f24a39c01b4f8eae466 Mon Sep 17 00:00:00 2001 From: Kp Date: Sat, 26 Nov 2016 22:51:48 +0000 Subject: [PATCH] Reorder newmenu length test to skip key_ascii() call --- similar/main/newmenu.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/similar/main/newmenu.cpp b/similar/main/newmenu.cpp index 8e6d84e68..32de898ab 100644 --- a/similar/main/newmenu.cpp +++ b/similar/main/newmenu.cpp @@ -1095,9 +1095,11 @@ static window_event_result newmenu_key_command(window *, const d_event &event, n if (citem.type == NM_TYPE_INPUT) changed = 1; rval = window_event_result::handled; - } else { + } + else if (citem.value < citem.input_or_menu()->text_len) + { auto ascii = key_ascii(); - if (ascii < 255 && citem.value < citem.input_or_menu()->text_len) + if (ascii < 255) { if (citem.value == -1) { citem.value = 0;