TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Tighten net_udp player index check

Browse source
This commit is contained in:
Kp 2022-05-29 19:37:58 +00:00
parent 0de494c2e0
commit a44324abe1
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
similar/main/net_udp.cpp
View file

@ -5490,10 +5490,13 @@ void net_udp_send_mdata(int needack, fix64 time)
void net_udp_process_mdata(uint8_t *data, uint_fast32_t data_len, const _sockaddr &sender_addr, int needack)
{
int pnum = data[1], dataoffset = (needack?6:2);
const unsigned pnum = data[1];
const unsigned dataoffset = needack ? 6 : 2;
// Check if packet might be bogus
if ((pnum < 0) || (data_len > sizeof(UDP_mdata_info)))
if (pnum >= MAX_PLAYERS)
return;
if (data_len > sizeof(UDP_mdata_info))
return;
// Check if it came from valid IP