TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Add static asserts that the custom resampler does not truncate input

Browse source
This commit is contained in:
Kp 2023-01-07 22:17:31 +00:00
parent f002678974
commit 9e3ebdb1f7
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
similar/arch/sdl/digi_mixer.cpp
View file

@ -234,10 +234,18 @@ static auto upsample(const std::span<const uint8_t> input, const std::size_t ups
*/
unique_span<int8_t> result(upsampledLen);
const auto output{result.span()};
using output_type = decltype(output)::value_type;
for (const auto ii : xrange(input.size()))
{
/* Assert that the minimum and maximum possible values in the input can
* be represented in the output without truncation. */
using conversion_type = int16_t;
using input_type = decltype(input)::value_type;
constexpr int8_t convert_u8_to_s8 = INT8_MIN;
static_assert(std::in_range<output_type>(conversion_type{input_type{0}} + convert_u8_to_s8));
static_assert(std::in_range<output_type>(conversion_type{input_type{UINT8_MAX}} + convert_u8_to_s8));
// Save input sample, convert to signed
output[ii*factor] = int16_t{input[ii]} - 128;
output[ii*factor] = conversion_type{input[ii]} + convert_u8_to_s8;
}
return result;
}