TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix -Wunused-variable warning in PNG screenshot code

Browse source 
Global `Viewer` was copied to local `viewer`, and the local should have
been used in this block.  Instead, the global was incorrectly used.
gcc-5 warns for this unused variable.  gcc-6 and gcc-7 incorrectly do
not warn.

Reported-by: Jayman2000 <https://github.com/dxx-rebirth/dxx-rebirth/issues/375>
Fixes: 131c1b9f4d ("Add support for PNG screenshots")
This commit is contained in:
Kp 2018-04-15 19:43:38 +00:00
parent 48b31d84f3
commit 8a16296eb4
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
similar/main/game.cpp
View file

@ -660,7 +660,7 @@ void record_screenshot_text_metadata(png_struct *const png_ptr, png_info *const
t.key = key_viewer_segment;
t.text = viewer_segment;
t.compression = PNG_TEXT_COMPRESSION_NONE;
snprintf(viewer_segment, sizeof(viewer_segment), "%hu", Viewer->segnum);
snprintf(viewer_segment, sizeof(viewer_segment), "%hu", viewer->segnum);
}
}
png_set_text(png_ptr, info_ptr, text_fields.data(), idx);