TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Drop useless test in render_side

Browse source 
Descent 2, but not Descent 1, had a useless test in render_side:

	type == QUAD ? 0 :
		type == TRI_13 ? 1 :
		0

This is useless since, if type is not QUAD, the second expression will
apply.  If type is QUAD, then the type is not TRI_13, so the second
expression would choose the same result as the first.  The extra
comparison does not save any work, so it is useless.  Remove it.
This commit is contained in:
Kp 2017-09-26 04:15:50 +00:00
parent f2a8be23a9
commit 6bd653bb16
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
similar/main/render.cpp
View file

@ -486,10 +486,6 @@ static void render_side(fvcvertptr &vcvertptr, grs_canvas &canvas, const vcsegpt
// deal with it, get the dot product.
const auto sidep = &segp->sides[sidenum];
const unsigned which_vertnum =
#if defined(DXX_BUILD_DESCENT_II)
/* Silly, but consistent with how it was at release */
(sidep->get_type() == SIDE_IS_QUAD) ? 0 :
#endif
(sidep->get_type() == SIDE_IS_TRI_13)
? 1
: 0;