TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Encourage std::fill to become memset

Browse source 
gcc has a special case to devolve to memset if both the pointed-at data
and the value to fill are considered a byte.  All uses of
DXX_POISON_MEMORY pass a value that fits in a byte, so change the
signature to be a byte, to encourage gcc to activate the special case.
This commit is contained in:
Kp 2020-05-17 23:35:26 +00:00
parent f413017317
commit 5c88587c01
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
common/include/compiler-poison.h
View file

@ -103,8 +103,8 @@ static inline void DXX_POISON_DEFINED_MEMORY(T b, unsigned long l, const V &v)
/* Poison a memory range, then mark it unreadable.
*/
template <typename T, typename V>
static inline void DXX_POISON_MEMORY(T b, unsigned long l, const V &v)
template <typename T>
static inline void DXX_POISON_MEMORY(T b, unsigned long l, const uint8_t v)
{
DXX_POISON_DEFINED_MEMORY(b, l, v);
DXX_MAKE_MEM_UNDEFINED(b, l);
@ -113,8 +113,8 @@ static inline void DXX_POISON_MEMORY(T b, unsigned long l, const V &v)
/* Convenience function to invoke
* `DXX_POISON_MEMORY(T &, unsigned long, V)`
*/
template <typename T, typename V>
static inline void DXX_POISON_MEMORY(T b, T e, const V &v)
template <typename T>
static inline void DXX_POISON_MEMORY(T b, T e, const uint8_t &&v)
{
DXX_POISON_MEMORY_RANGE(b, e, v);
DXX_MAKE_MEM_UNDEFINED(b, e);
@ -125,7 +125,7 @@ static inline void DXX_POISON_MEMORY(T b, T e, const V &v)
* of `T`.
*/
template <typename T>
static inline void DXX_POISON_VAR(T &b, const unsigned char v)
static inline void DXX_POISON_VAR(T &b, const uint8_t v)
{
DXX_POISON_MEMORY(reinterpret_cast<unsigned char *>(std::addressof(b)), sizeof(T), v);
}