TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Reorder check_line_to_line to eliminate useless copy

Browse source 
Instead of copying the input v1/v2 into det.uvec, pass a reference for
v1/v2 directly to calc_det_value.
This commit is contained in:
Kp 2022-06-05 17:44:53 +00:00
parent 9071675a0d
commit 5be32a05c6
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
similar/main/fvi.cpp
View file

@ -288,23 +288,21 @@ static fix calc_det_value(const std::pair<vms_vector, vms_vector> &rfvec, const
[[nodiscard]]
static std::optional<std::pair<fix, fix>> check_line_to_line(const vms_vector &p1, const vms_vector &v1, const vms_vector &p2, const vms_vector &v2)
{
vms_matrix det;
fix d,cross_mag2; //mag squared cross product
vm_vec_cross(det.fvec,v1,v2);
cross_mag2 = vm_vec_dot(det.fvec,det.fvec);
std::pair<vms_vector, vms_vector> rfvec;
auto &detf = rfvec.second;
vm_vec_cross(detf, v1, v2);
const auto cross_mag2 = vm_vec_dot(detf, detf);
if (cross_mag2 == 0)
return std::nullopt; //lines are parallel
vm_vec_sub(det.rvec,p2,p1);
det.uvec = v2;
d = calc_det_value({det.rvec, det.fvec}, det.uvec);
const auto t1 = fixdiv(d, cross_mag2);
auto &detr = rfvec.first;
vm_vec_sub(detr, p2, p1);
const auto dv2 = calc_det_value(rfvec, v2);
const auto dv1 = calc_det_value(rfvec, v1);
det.uvec = v1;
d = calc_det_value({det.rvec, det.fvec}, det.uvec);
const auto t2 = fixdiv(d, cross_mag2);
const auto t1 = fixdiv(dv2, cross_mag2);
const auto t2 = fixdiv(dv1, cross_mag2);
return std::pair(t1, t2); //found point
}