TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Factor out set_color_by_model_light color

Browse source 
Optimizing compilers tend to factor out color automatically.  Move it up
to the caller to ensure that it is computed once even if the compiler
does not optimize aggressively.
This commit is contained in:
Kp 2016-09-26 00:50:09 +00:00
parent cc2fd7071d
commit 56e4f6b6f7
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
similar/3d/interp.cpp
View file

@ -201,9 +201,8 @@ private:
{
rotate_point_list(&Interp_point_list[i], src, n);
}
void set_color_by_model_light(fix g3s_lrgb::*const c, g3s_lrgb &o, const fix negdot) const
void set_color_by_model_light(fix g3s_lrgb::*const c, g3s_lrgb &o, const fix color) const
{
const auto color = (f1_0 / 4) + ((negdot * 3) / 4);
o.*c = fixmul(color, model_light.*c);
}
protected:
@ -211,9 +210,10 @@ protected:
{
g3s_lrgb light;
const auto negdot = -vm_vec_dot(View_matrix.fvec, *vp(p + 16));
set_color_by_model_light(&g3s_lrgb::r, light, negdot);
set_color_by_model_light(&g3s_lrgb::g, light, negdot);
set_color_by_model_light(&g3s_lrgb::b, light, negdot);
const auto color = (f1_0 / 4) + ((negdot * 3) / 4);
set_color_by_model_light(&g3s_lrgb::r, light, color);
set_color_by_model_light(&g3s_lrgb::g, light, color);
set_color_by_model_light(&g3s_lrgb::b, light, color);
return light;
}
g3_interpreter_draw_base(grs_bitmap **mbitmaps, const submodel_angles aangles, polygon_model_points &plist, const g3s_lrgb &mlight) :