From 504e950b755a5cb827a89be04116d29b47c077f9 Mon Sep 17 00:00:00 2001
From: Kp <kp@valhallalegends.com>
Date: Sun, 5 Jun 2022 17:44:53 +0000
Subject: [PATCH] Simplify bm_read_player_ship last_model_num handling

The existing handling always wrote to slot 0, but did so in a convoluted
way.  The variable names suggest this was not intended, but no one has
ever reported it as broken, and some otherwise valid data files may
depend on this quirk.
---
 similar/main/bmread.cpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/similar/main/bmread.cpp b/similar/main/bmread.cpp
index fd2583e9d..901f947a8 100644
--- a/similar/main/bmread.cpp
+++ b/similar/main/bmread.cpp
@@ -2024,7 +2024,6 @@ void bm_read_player_ship(void)
 	auto &Polygon_models = LevelSharedPolygonModelState.Polygon_models;
 	for (i=0;i<n_models;i++) {
 		int n_textures;
-		int last_model_num=0;
 
 		n_textures = first_bitmap_num[i+1] - first_bitmap_num[i];
 		const auto model_num = load_polygon_model(model_name[i], n_textures, first_bitmap_num[i], (i == 0) ? &ri : nullptr);
@@ -2032,9 +2031,7 @@ void bm_read_player_ship(void)
 		if (i==0)
 			Player_ship->model_num = model_num;
 		else
-			Polygon_models[last_model_num].simpler_model = model_num+1;
-
-		last_model_num = model_num;
+			Polygon_models[0].simpler_model = model_num+1;
 	}
 
 	if ( model_name_dying ) {