TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Avoid passing pointer to uninitialized last_game to scores_view

Browse source 
The position parameter should avoid the value being used, but avoid
passing a pointer to known-uninitialized data to be safe.
This commit is contained in:
Kp 2020-12-20 20:39:07 +00:00
parent 7da06d916c
commit 305c3dc04c
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
similar/main/scores.cpp
View file

@ -284,9 +284,12 @@ void scores_maybe_add_player()
break;
}
}
if ( position == MAX_HIGH_SCORES ) {
scores_fill_struct( &last_game );
stats_info *const ptr_last_game = (position == MAX_HIGH_SCORES)
? &last_game
: nullptr;
if (ptr_last_game)
{
scores_fill_struct(ptr_last_game);
} else {
if ( position==0 ) {
std::array<char, sizeof(scores.cool_saying)> text1{};
@ -308,9 +311,8 @@ void scores_maybe_add_player()
scores_fill_struct( &scores.stats[position] );
scores_write(&scores);
}
scores_view(&last_game, position);
scores_view(ptr_last_game, position);
}
}