TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Mark editor groups broken

Browse source 
Editor groups write `struct segment` to a file in raw form, but had no
code to enforce that this raw form remained stable over time.  Various
changes to `struct segment` have repeatedly changed its internal
structure.  Each change created an incompatible dialect of the editor
group file, and all the dialects share the same version number.

According to
```
git log -p -L'/struct segment {/,/};/:common/main/segment.h' HEAD --not 0.58.1-d1x 0.58.1-d2x --
```
`struct segment` changed layout in:

* d1c6b89f17 ("Move dsx::segment -> dcx::segment")	[D1 only]
* 596ecbb38d ("Rename segment::value to segment::station_idx")	[D1 only]
* 6f10a67c09 ("Move segment::sides to end")
* c53b734abb ("Compute slide segments early")	[D2 only]
* 40e90fea22 ("Move Light_subtracted[] to Segments[].light_subtracted")
* a65d774c83 ("Improve packing of struct segment")
* c70c6c98b3 ("Remove obsolete segment::degenerated flag")

Mark editor groups as broken to avoid making the mess worse.  If anyone
cares about group support, it needs to be rewritten not to depend on the
internal layout of `struct segment`.
This commit is contained in:
Kp 2017-09-30 18:00:15 +00:00
parent 7bae498c45
commit 2665869c24
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
similar/editor/group.cpp
View file

@ -954,6 +954,7 @@ int RotateSegmentNew(vms_angvec *pbh)
return rval;
}
#if 0
static array<d_fname, MAX_TEXTURES> current_tmap_list;
// -----------------------------------------------------------------------------
@ -1356,12 +1357,16 @@ static void checkforgrpext( char * f )
return;
}
}
#endif
//short vertex_list[MAX_VERTICES];
int SaveGroup()
{
ui_messagebox(-2, -2, 1, "ERROR: Groups are broken.", "Ok");
return 0;
#if 0
// Save group
int i;
@ -1395,11 +1400,15 @@ int SaveGroup()
}
return 1;
#endif
}
int LoadGroup()
{
ui_messagebox(-2, -2, 1, "ERROR: Groups are broken.", "Ok");
return 0;
#if 0
int x;
if (num_groups == MAX_GROUPS)
@ -1433,6 +1442,7 @@ int LoadGroup()
} else
return 1;
#endif
}