TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Remove mix_play_file use of PHYSFSX_getRealPath

Browse source 
If the file is accessible via PhysFS, the next branch, based on
PHYSFS_openRead, will find it and use it.  If it is not accessible via
PhysFS, then attempting to resolve its path would fail.  Thus, this
attempt is redundant regardless of whether the file is reachable by
PhysFS.  Remove it.
This commit is contained in:
Kp 2022-03-19 22:55:58 +00:00
parent 9cdf9152bc
commit 2099c54ac7
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
common/arch/sdl/digi_mixer_music.cpp
View file

@ -193,14 +193,6 @@ int mix_play_file(const char *filename, int loop, void (*const entry_hook_finish
return 1;
}
// no luck. so it might be in Searchpath. So try to build absolute path
if (PHYSFSX_getRealPath(filename, full_path))
{
current_music_type = load_mus_file(full_path.data(), loop, hook_finished_track);
if (current_music_type != CurrentMusicType::None)
return 1;
}
// still nothin'? Let's open via PhysFS in case it's located inside an archive
{
if (RAIIPHYSFS_File filehandle{PHYSFS_openRead(filename)})