TakeV
/
dino
mirror of https://github.com/TakeV-Lambda/dino.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix compiler warnings

This commit is contained in:
fiaxh 2022-11-26 22:26:25 +01:00
parent 799d09a4c9
commit 4d7809bb12
12 changed files with 11 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libdino/src/service/calls.vala
View File

@ -82,7 +82,6 @@ namespace Dino {
return (yield get_call_resources(conversation.account, conversation.counterpart)).size > 0 || has_jmi_resources(conversation.counterpart);
} else {
bool is_private = stream_interactor.get_module(MucManager.IDENTITY).is_private_room(conversation.account, conversation.counterpart);
EntityInfo entity_info = stream_interactor.get_module(EntityInfo.IDENTITY);
return is_private && can_initiate_groupcall(conversation.account);
}
}

2
libdino/src/service/history_sync.vala
View File

@ -315,7 +315,7 @@ public class Dino.HistorySync {
latest_time, latest_id
);
}
PageRequestResult page_result = yield fetch_query(account, query_params, range[db.mam_catchup.id]);
yield fetch_query(account, query_params, range[db.mam_catchup.id]);
}
/**

2
libdino/src/service/jingle_file_transfers.vala
View File

@ -115,8 +115,6 @@ public class JingleFileProvider : FileProvider, Object {
}
private void on_account_added(Account account) {
XmppStream stream = stream_interactor.get_stream(account);
stream_interactor.module_manager.get_module(account, Xmpp.Xep.JingleFileTransfer.Module.IDENTITY).file_incoming.connect((stream, jingle_file_transfer) => {
Conversation? conversation = stream_interactor.get_module(ConversationManager.IDENTITY).get_conversation(jingle_file_transfer.peer.bare_jid, account);
if (conversation == null) return;

2
libdino/src/service/message_processor.vala
View File

@ -128,7 +128,7 @@ public class MessageProcessor : StreamInteractionModule, Object {
// If it's a message from MAM, it's going to be processed by HistorySync which calls run_pipeline_announce later.
if (history_sync.process(account, message_stanza)) return;
run_pipeline_announce(account, message_stanza);
run_pipeline_announce.begin(account, message_stanza);
}
public async void run_pipeline_announce(Account account, Xmpp.MessageStanza message_stanza) {

4
libdino/src/service/muc_manager.vala
View File

@ -387,7 +387,7 @@ public class MucManager : StreamInteractionModule, Object {
}
public string? get_own_occupant_id(Account account, Jid muc_jid) {
if (account in own_occupant_ids && muc_jid in own_occupant_ids[account]) {
if (own_occupant_ids.has_key(account) && own_occupant_ids[account].has_key(muc_jid)) {
return own_occupant_ids[account][muc_jid];
}
return null;
@ -421,7 +421,7 @@ public class MucManager : StreamInteractionModule, Object {
}
});
stream_interactor.module_manager.get_module(account, Xep.OccupantIds.Module.IDENTITY).received_own_occupant_id.connect( (stream, jid, occupant_id) => {
if (!(account in own_occupant_ids)) {
if (!own_occupant_ids.has_key(account)) {
own_occupant_ids[account] = new HashMap<Jid, string>(Jid.hash_bare_func, Jid.equals_bare_func);
}
own_occupant_ids[account][jid] = occupant_id;

1
main/src/ui/chat_input/encryption_button.vala
View File

@ -11,7 +11,6 @@ public class EncryptionButton {
private MenuButton menu_button;
private Conversation? conversation;
private CheckButton? button_unencrypted;
private string? current_icon;
private StreamInteractor stream_interactor;
private SimpleAction action;

3
main/src/ui/conversation_content_view/conversation_item_skeleton.vala
View File

@ -43,6 +43,9 @@ public class ConversationItemSkeleton : Plugins.ConversationItemWidgetInterface,
this.item = item;
this.content_meta_item = item as ContentMetaItem;
item.bind_property("in-edit-mode", this, "item-in-edit-mode");
this.notify["item-in-edit-mode"].connect(update_edit_mode);
Builder builder = new Builder.from_resource("/im/dino/Dino/conversation_item_widget.ui");
main_grid = (Grid) builder.get_object("main_grid");
main_grid.add_css_class("message-box");

2
main/src/ui/conversation_content_view/conversation_view.vala
View File

@ -136,7 +136,6 @@ public class ConversationView : Widget, Plugins.ConversationItemCollection, Plug
// Get widget under pointer
int h = 0;
Widget? w = null;
Plugins.MetaConversationItem? meta_item = null;
foreach (Plugins.MetaConversationItem item in meta_items) {
Widget widget = widgets[item];
h += widget.get_allocated_height() + widget.margin_top + widget.margin_bottom;
@ -404,7 +403,6 @@ public class ConversationView : Widget, Plugins.ConversationItemCollection, Plug
if (lower_item != null) {
if (can_merge(item, lower_item)) {
ConversationItemSkeleton lower_skeleton = item_item_skeletons[lower_item];
item_skeleton.show_skeleton = false;
} else {
item_skeleton.show_skeleton = true;

1
main/src/ui/conversation_content_view/file_image_widget.vala
View File

@ -35,7 +35,6 @@ public class FileImageWidget : Box {
pixbuf = pixbuf.apply_embedded_orientation();
image.load(pixbuf);
Picture picture = new Picture.for_pixbuf(pixbuf) { can_shrink=true, keep_aspect_ratio=true, halign=Align.START };
Idle.add(load_from_file.callback);
return image;

18
main/src/ui/conversation_view.vala
View File

@ -28,9 +28,6 @@ public class ConversationView : Widget {
// conversation_scrolled.set_child(list_view);
// list_view.set_factory(get_item_factory());
// conversation_scrolled.vadjustment.notify["upper"].connect_after(on_upper_notify);
// conversation_scrolled.vadjustment.notify["value"].connect(on_value_notify);
}
public void add_overlay_dialog(Widget widget) {
@ -54,21 +51,6 @@ public class ConversationView : Widget {
white_revealer.visible = false;
}
}
private void on_upper_notify() {
print("on_upper_notify\n");
if (at_current_content) {
print("on_upper_notify2\n");
// scroll down
// conversation_scrolled.vadjustment.value = conversation_scrolled.vadjustment.upper - conversation_scrolled.vadjustment.page_size;
// conversation_scrolled.scroll_child(ScrollType.END, false);
}
}
private void on_value_notify() {
print("on_value_notify\n");
// at_current_content = false;
}
}
}

7
main/src/ui/conversation_view_controller.vala
View File

@ -146,7 +146,7 @@ public class ConversationViewController : Object {
view.conversation_frame.initialize_for_conversation(conversation);
}
update_file_upload_status();
update_file_upload_status.begin();
}
public void unset_conversation() {
@ -159,6 +159,7 @@ public class ConversationViewController : Object {
bool upload_available = yield stream_interactor.get_module(FileManager.IDENTITY).is_upload_available(conversation);
chat_input_controller.set_file_upload_active(upload_available);
if (upload_available && overlay_dialog == null) {
if (drop_event_controller.widget == null) {
view.add_controller(drop_event_controller);
@ -246,13 +247,13 @@ public class ConversationViewController : Object {
overlay.close.connect(() => {
// We don't want drag'n'drop to be active while the overlay is active
overlay_dialog = null;
update_file_upload_status();
update_file_upload_status.begin();
});
view.add_overlay_dialog(overlay.get_widget());
overlay_dialog = overlay.get_widget();
update_file_upload_status();
update_file_upload_status.begin();
}
private void send_file(File file) {

1
plugins/omemo/src/ui/manage_key_dialog.vala
View File

@ -6,7 +6,6 @@ namespace Dino.Plugins.Omemo {
[GtkTemplate (ui = "/im/dino/Dino/omemo/manage_key_dialog.ui")]
public class ManageKeyDialog : Gtk.Dialog {
[GtkChild] private unowned HeaderBar headerbar;
[GtkChild] private unowned Stack manage_stack;
[GtkChild] private unowned Button cancel_button;