70ce6ce831
This makes it easier for downstream projects (forks) to replace the version fetching system with their own. It is as simple as implementing an interface and overriding the default implementation of org.bukkit.UnsafeValues#getVersionFetcher() It also makes it easier for us to organize things like the version history feature. Lastly I have updated the paper implementation to check against the site API rather than against jenkins.
28 lines
1.2 KiB
Diff
28 lines
1.2 KiB
Diff
From e718538a8b3799242006d95332319c9de15f4f3b Mon Sep 17 00:00:00 2001
|
|
From: Aikar <aikar@aikar.co>
|
|
Date: Sat, 22 Sep 2018 18:41:01 -0400
|
|
Subject: [PATCH] Remove Precondition on name for AttributeModifier
|
|
|
|
Vanilla allows empty names
|
|
|
|
diff --git a/src/main/java/org/bukkit/attribute/AttributeModifier.java b/src/main/java/org/bukkit/attribute/AttributeModifier.java
|
|
index a9763147..f0dff145 100644
|
|
--- a/src/main/java/org/bukkit/attribute/AttributeModifier.java
|
|
+++ b/src/main/java/org/bukkit/attribute/AttributeModifier.java
|
|
@@ -32,10 +32,10 @@ public class AttributeModifier implements ConfigurationSerializable {
|
|
|
|
public AttributeModifier(@NotNull UUID uuid, @NotNull String name, double amount, @NotNull Operation operation, @Nullable EquipmentSlot slot) {
|
|
Validate.notNull(uuid, "UUID cannot be null");
|
|
- Validate.notEmpty(name, "Name cannot be empty");
|
|
+ //Validate.notEmpty(name, "Name cannot be empty"); // Paper
|
|
Validate.notNull(operation, "Operation cannot be null");
|
|
this.uuid = uuid;
|
|
- this.name = name;
|
|
+ this.name = name != null ? name : ""; // Paper
|
|
this.amount = amount;
|
|
this.operation = operation;
|
|
this.slot = slot;
|
|
--
|
|
2.21.0
|
|
|