the first 'major' change in this PR is to cache the generated event executrs from the ASM class, by doing this we only generate a single class for every method that we need an executor for, thus reducing the number of classes that are needed, especially in cases where plugins re/unregister events all the time. The second change is to modify the generated classloader map, generated classloaders are not held against the plugin itself but the classloader that the event is declared in, the implication here is that we cannot drop generated classloaders when a plugin disable, and so we use a guava weak-key'd hashmap, downfall here is that classes won't be GC'd until guava drops the generated classloader, however the first change should deal with most of the grunt.
39 lines
1.3 KiB
Diff
39 lines
1.3 KiB
Diff
From 3a5f33ba756ff0587b88c7b6340ff6368131f51e Mon Sep 17 00:00:00 2001
|
|
From: Aikar <aikar@aikar.co>
|
|
Date: Sat, 17 Jun 2017 15:04:51 -0400
|
|
Subject: [PATCH] Shoulder Entities Release API
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/entity/HumanEntity.java b/src/main/java/org/bukkit/entity/HumanEntity.java
|
|
index 518aa2a9..3939d4af 100644
|
|
--- a/src/main/java/org/bukkit/entity/HumanEntity.java
|
|
+++ b/src/main/java/org/bukkit/entity/HumanEntity.java
|
|
@@ -256,6 +256,24 @@ public interface HumanEntity extends LivingEntity, AnimalTamer, Permissible, Inv
|
|
*/
|
|
public int getExpToLevel();
|
|
|
|
+ // Paper start
|
|
+ /**
|
|
+ * If there is an Entity on this entities left shoulder, it will be released to the world and returned.
|
|
+ * If no Entity is released, null will be returned.
|
|
+ *
|
|
+ * @return The released entity, or null
|
|
+ */
|
|
+ public Entity releaseLeftShoulderEntity();
|
|
+
|
|
+ /**
|
|
+ * If there is an Entity on this entities left shoulder, it will be released to the world and returned.
|
|
+ * If no Entity is released, null will be returned.
|
|
+ *
|
|
+ * @return The released entity, or null
|
|
+ */
|
|
+ public Entity releaseRightShoulderEntity();
|
|
+ // Paper end
|
|
+
|
|
/**
|
|
* Gets the entity currently perched on the left shoulder or null if no
|
|
* entity.
|
|
--
|
|
2.14.1
|
|
|