From 6e8e4cc4a23eb58b2f6e536c04485d4b9874d97b Mon Sep 17 00:00:00 2001 From: Zach Brown Date: Tue, 28 Aug 2018 23:04:15 -0400 Subject: [PATCH] Inventory#removeItemAnySlot diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftInventory.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftInventory.java index 9fbedcede8..b7e08b55f9 100644 --- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftInventory.java +++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftInventory.java @@ -224,10 +224,16 @@ public class CraftInventory implements Inventory { } private int first(ItemStack item, boolean withAmount) { + // Paper start + return first(item, withAmount, getStorageContents()); + } + + private int first(ItemStack item, boolean withAmount, ItemStack[] inventory) { + // Paper end if (item == null) { return -1; } - ItemStack[] inventory = getStorageContents(); + //ItemStack[] inventory = getStorageContents(); // Paper - let param deal for (int i = 0; i < inventory.length; i++) { if (inventory[i] == null) continue; @@ -345,6 +351,17 @@ public class CraftInventory implements Inventory { @Override public HashMap removeItem(ItemStack... items) { + // Paper start + return removeItem(false, items); + } + + @Override + public HashMap removeItemAnySlot(ItemStack... items) { + return removeItem(true, items); + } + + private HashMap removeItem(boolean searchEntire, ItemStack... items) { + // Paper end Validate.notNull(items, "Items cannot be null"); HashMap leftover = new HashMap(); @@ -355,7 +372,10 @@ public class CraftInventory implements Inventory { int toDelete = item.getAmount(); while (true) { - int first = first(item, false); + // Paper start - Allow searching entire contents + ItemStack[] toSearch = searchEntire ? getContents() : getStorageContents(); + int first = first(item, false, toSearch); + // Paper end // Drat! we don't have this type in the inventory if (first == -1) { -- 2.21.0