From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Jake Potrebic Date: Thu, 27 May 2021 21:58:33 -0700 Subject: [PATCH] More PotionEffectType API diff --git a/src/main/java/org/bukkit/Registry.java b/src/main/java/org/bukkit/Registry.java index bfe0d98e6032c7633d6bb97382426f94fb437430..798aab0d644ca383ff4391685d854af65925fb0c 100644 --- a/src/main/java/org/bukkit/Registry.java +++ b/src/main/java/org/bukkit/Registry.java @@ -195,6 +195,25 @@ public interface Registry extends Iterable { * @see io.papermc.paper.world.structure.ConfiguredStructure */ Registry CONFIGURED_STRUCTURE = Bukkit.getUnsafe().registryFor(io.papermc.paper.world.structure.ConfiguredStructure.class); + /** + * Potion effect types. + * + * @see org.bukkit.potion.PotionEffectType + */ + Registry POTION_EFFECT_TYPE = new Registry() { + + @Nullable + @Override + public org.bukkit.potion.PotionEffectType get(@NotNull NamespacedKey key) { + return org.bukkit.potion.PotionEffectType.getByKey(key); + } + + @NotNull + @Override + public Iterator iterator() { + return Arrays.stream(org.bukkit.potion.PotionEffectType.values()).iterator(); + } + }; // Paper end /** diff --git a/src/main/java/org/bukkit/potion/PotionEffectType.java b/src/main/java/org/bukkit/potion/PotionEffectType.java index 22c28a503732671bc84c51372262e909d035c1fa..06e0f13d658b63b1fa984abb515eb0de704f9215 100644 --- a/src/main/java/org/bukkit/potion/PotionEffectType.java +++ b/src/main/java/org/bukkit/potion/PotionEffectType.java @@ -14,7 +14,7 @@ import org.jetbrains.annotations.Nullable; /** * Represents a type of potion and its effect on an entity. */ -public abstract class PotionEffectType implements Keyed { +public abstract class PotionEffectType implements Keyed, net.kyori.adventure.translation.Translatable { // Paper - implement Translatable /** * Increases movement speed. */ @@ -358,4 +358,56 @@ public abstract class PotionEffectType implements Keyed { public static PotionEffectType[] values() { return Arrays.copyOfRange(byId, 1, byId.length); } + // Paper start + /** + * Gets the effect attributes in an immutable map. + * + * @return the attribute map + */ + public abstract @NotNull Map getEffectAttributes(); + + /** + * Gets the true modifier amount based on the effect amplifier. + * + * @param attribute the attribute + * @param effectAmplifier the effect amplifier (0 indexed) + * @return the modifier amount + * @throws IllegalArgumentException if the supplied attribute is not present in the map from {@link #getEffectAttributes()} + */ + public abstract double getAttributeModifierAmount(@NotNull org.bukkit.attribute.Attribute attribute, int effectAmplifier); + + /** + * Gets the category of this effect + * + * @return the category + */ + public abstract @NotNull PotionEffectType.Category getEffectCategory(); + + /** + * Category of {@link PotionEffectType}s + */ + public enum Category { + + BENEFICIAL(net.kyori.adventure.text.format.NamedTextColor.BLUE), + HARMFUL(net.kyori.adventure.text.format.NamedTextColor.RED), + NEUTRAL(net.kyori.adventure.text.format.NamedTextColor.BLUE); + + private final net.kyori.adventure.text.format.TextColor color; + + Category(net.kyori.adventure.text.format.TextColor color) { + this.color = color; + } + + /** + * Gets the text color used when displaying potions + * of this category. + * + * @return the text color + */ + @NotNull + public net.kyori.adventure.text.format.TextColor getColor() { + return color; + } + } + // Paper end } diff --git a/src/main/java/org/bukkit/potion/PotionEffectTypeWrapper.java b/src/main/java/org/bukkit/potion/PotionEffectTypeWrapper.java index c3a86bb1910158a8d13a675dfa7236dd6a3f397c..a7653806c0fa76f4b3342ea199fe892c514a4c27 100644 --- a/src/main/java/org/bukkit/potion/PotionEffectTypeWrapper.java +++ b/src/main/java/org/bukkit/potion/PotionEffectTypeWrapper.java @@ -40,4 +40,30 @@ public class PotionEffectTypeWrapper extends PotionEffectType { public Color getColor() { return getType().getColor(); } + // Paper start + @Override + public @NotNull org.bukkit.NamespacedKey getKey() { + return this.getType().getKey(); + } + + @Override + public @NotNull java.util.Map getEffectAttributes() { + return this.getType().getEffectAttributes(); + } + + @Override + public double getAttributeModifierAmount(@NotNull org.bukkit.attribute.Attribute attribute, int effectAmplifier) { + return this.getType().getAttributeModifierAmount(attribute, effectAmplifier); + } + + @Override + public @NotNull PotionEffectType.Category getEffectCategory() { + return this.getType().getEffectCategory(); + } + + @Override + public @NotNull String translationKey() { + return this.getType().translationKey(); + } + // Paper end }