From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: William Blake Galbreath Date: Wed, 1 Jul 2020 11:57:40 -0500 Subject: [PATCH] Update itemstack legacy name and lore diff --git a/src/main/java/net/minecraft/world/item/ItemStack.java b/src/main/java/net/minecraft/world/item/ItemStack.java index 0468f80b7f52ee45fc9364470b23f80f7cd0cb57..158c7a30af8326fa419af391167c07d75b8611ac 100644 --- a/src/main/java/net/minecraft/world/item/ItemStack.java +++ b/src/main/java/net/minecraft/world/item/ItemStack.java @@ -27,6 +27,7 @@ import net.minecraft.core.IRegistry; import net.minecraft.nbt.NBTBase; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.nbt.NBTTagList; +import net.minecraft.nbt.NBTTagString; import net.minecraft.network.chat.ChatComponentText; import net.minecraft.network.chat.ChatComponentUtils; import net.minecraft.network.chat.ChatHoverable; @@ -137,6 +138,44 @@ public final class ItemStack { list.sort((Comparator) enchantSorter); // Paper } catch (Exception ignored) {} } + + private void processText() { + NBTTagCompound display = getSubTag("display"); + if (display != null) { + if (display.hasKeyOfType("Name", 8)) { + String json = display.getString("Name"); + if (json != null && json.contains("\u00A7")) { + try { + display.set("Name", convert(json)); + } catch (JsonParseException jsonparseexception) { + display.remove("Name"); + } + } + } + if (display.hasKeyOfType("Lore", 9)) { + NBTTagList list = display.getList("Lore", 8); + for (int index = 0; index < list.size(); index++) { + String json = list.getString(index); + if (json != null && json.contains("\u00A7")) { // Only try if it has legacy in the unparsed json + try { + list.set(index, convert(json)); + } catch (JsonParseException e) { + list.set(index, NBTTagString.create(org.bukkit.craftbukkit.util.CraftChatMessage.toJSON(new ChatComponentText("")))); + } + } + } + } + } + } + + private NBTTagString convert(String json) { + IChatBaseComponent component = IChatBaseComponent.ChatSerializer.jsonToComponent(json); + if (component instanceof ChatComponentText && component.getText().contains("\u00A7") && component.getSiblings().isEmpty()) { + // Only convert if the root component is a single comp with legacy in it, don't convert already normal components + component = org.bukkit.craftbukkit.util.CraftChatMessage.fromString(component.getText())[0]; + } + return NBTTagString.create(org.bukkit.craftbukkit.util.CraftChatMessage.toJSON(component)); + } // Paper end public ItemStack(IMaterial imaterial) { @@ -182,6 +221,7 @@ public final class ItemStack { // CraftBukkit start - make defensive copy as this data may be coming from the save thread this.tag = (NBTTagCompound) nbttagcompound.getCompound("tag").clone(); processEnchantOrder(this.tag); // Paper + processText(); // Paper this.getItem().b(this.tag); // CraftBukkit end } @@ -665,6 +705,7 @@ public final class ItemStack { } } + @Nullable public NBTTagCompound getSubTag(String s) { return b(s); } // Paper - OBFHELPER @Nullable public NBTTagCompound b(String s) { return this.tag != null && this.tag.hasKeyOfType(s, 10) ? this.tag.getCompound(s) : null;