TakeV/Paper
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
Paper/Spigot-Server-Patches/0458-Increase-Light-Queue-Size.patch

46 lines
2 KiB
Diff
Raw Normal View History

Anti Xray cleanup Undo the accidental renaming of a method in 0aad8bf Aikar wanted to rename DataPalette#getDataBits(T object) to getOrCreateIdFor in 0aad8bf but he also accidentally renamed ChunkPacketInfo#getDataBitsIndex(int chunkSectionIndex) to getOrCreateIdForIndex. Remove chunk-edge-mode and chunk loading entirely from Anti-Xray The chunk-edge-mode is broken since several versions. Loading chunk neighbors for chunk edge obfuscation isn't needed anymore. Unlike in previous versions, these are under normal circumstances already loaded at the time we need them (plugins for example can bypass this). Use the modified methods and constructors everywhere Anti-Xray provides support for the default nms methods and constructors, which where modified by Anti-Xray to avoid breaking stuff (plugins) which somehow uses these methods. However, the modified versions of those methods and constructors should be used where possible.
2020-05-06 08:35:20 +00:00
From a6e7765b2ccf8621cbef028703c1a20ad6a03a0f Mon Sep 17 00:00:00 2001
Increase Light Queue Size Wiz mentioned that large WorldEdit operations cause light to run on main thread. The queue was small, set to 5.. this bumps it to 20 but makes it configurable per-world. The main risk of increasing this higher is during shutdown, some queued light updates may be lost because mojang did not flush the light engine on shutdown... The queue size only puts a cap on max loss, doesn't solve that problem. Don't touch this unless you know you have a problem and ok with the risk.
2020-04-09 01:36:10 +00:00
From: Aikar <aikar@aikar.co>
Date: Wed, 8 Apr 2020 21:24:05 -0400
Subject: [PATCH] Increase Light Queue Size
Wiz mentioned that large WorldEdit operations cause light to run on
main thread. The queue was small, set to 5.. this bumps it to 20
but makes it configurable per-world.
The main risk of increasing this higher is during shutdown, some
queued light updates may be lost because mojang did not flush the
light engine on shutdown...
The queue size only puts a cap on max loss, doesn't solve that problem.
diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
Anti Xray cleanup Undo the accidental renaming of a method in 0aad8bf Aikar wanted to rename DataPalette#getDataBits(T object) to getOrCreateIdFor in 0aad8bf but he also accidentally renamed ChunkPacketInfo#getDataBitsIndex(int chunkSectionIndex) to getOrCreateIdForIndex. Remove chunk-edge-mode and chunk loading entirely from Anti-Xray The chunk-edge-mode is broken since several versions. Loading chunk neighbors for chunk edge obfuscation isn't needed anymore. Unlike in previous versions, these are under normal circumstances already loaded at the time we need them (plugins for example can bypass this). Use the modified methods and constructors everywhere Anti-Xray provides support for the default nms methods and constructors, which where modified by Anti-Xray to avoid breaking stuff (plugins) which somehow uses these methods. However, the modified versions of those methods and constructors should be used where possible.
2020-05-06 08:35:20 +00:00
index 3f44be577e3..a4815f5e69c 100644
Increase Light Queue Size Wiz mentioned that large WorldEdit operations cause light to run on main thread. The queue was small, set to 5.. this bumps it to 20 but makes it configurable per-world. The main risk of increasing this higher is during shutdown, some queued light updates may be lost because mojang did not flush the light engine on shutdown... The queue size only puts a cap on max loss, doesn't solve that problem. Don't touch this unless you know you have a problem and ok with the risk.
2020-04-09 01:36:10 +00:00
--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
+++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
Anti Xray cleanup Undo the accidental renaming of a method in 0aad8bf Aikar wanted to rename DataPalette#getDataBits(T object) to getOrCreateIdFor in 0aad8bf but he also accidentally renamed ChunkPacketInfo#getDataBitsIndex(int chunkSectionIndex) to getOrCreateIdForIndex. Remove chunk-edge-mode and chunk loading entirely from Anti-Xray The chunk-edge-mode is broken since several versions. Loading chunk neighbors for chunk edge obfuscation isn't needed anymore. Unlike in previous versions, these are under normal circumstances already loaded at the time we need them (plugins for example can bypass this). Use the modified methods and constructors everywhere Anti-Xray provides support for the default nms methods and constructors, which where modified by Anti-Xray to avoid breaking stuff (plugins) which somehow uses these methods. However, the modified versions of those methods and constructors should be used where possible.
2020-05-06 08:35:20 +00:00
@@ -667,4 +667,9 @@ public class PaperWorldConfig {
Use distance map to optimise entity tracker / Misc Utils Use the distance map to find candidate players for tracking. This also ports a few utility changes from Tuinity
2020-05-06 07:44:47 +00:00
private void zombieVillagerInfectionChance() {
zombieVillagerInfectionChance = getDouble("zombie-villager-infection-chance", zombieVillagerInfectionChance);
Increase Light Queue Size Wiz mentioned that large WorldEdit operations cause light to run on main thread. The queue was small, set to 5.. this bumps it to 20 but makes it configurable per-world. The main risk of increasing this higher is during shutdown, some queued light updates may be lost because mojang did not flush the light engine on shutdown... The queue size only puts a cap on max loss, doesn't solve that problem. Don't touch this unless you know you have a problem and ok with the risk.
2020-04-09 01:36:10 +00:00
}
+
+ public int lightQueueSize = 20;
+ private void lightQueueSize() {
+ lightQueueSize = getInt("light-queue-size", lightQueueSize);
+ }
}
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
Anti Xray cleanup Undo the accidental renaming of a method in 0aad8bf Aikar wanted to rename DataPalette#getDataBits(T object) to getOrCreateIdFor in 0aad8bf but he also accidentally renamed ChunkPacketInfo#getDataBitsIndex(int chunkSectionIndex) to getOrCreateIdForIndex. Remove chunk-edge-mode and chunk loading entirely from Anti-Xray The chunk-edge-mode is broken since several versions. Loading chunk neighbors for chunk edge obfuscation isn't needed anymore. Unlike in previous versions, these are under normal circumstances already loaded at the time we need them (plugins for example can bypass this). Use the modified methods and constructors everywhere Anti-Xray provides support for the default nms methods and constructors, which where modified by Anti-Xray to avoid breaking stuff (plugins) which somehow uses these methods. However, the modified versions of those methods and constructors should be used where possible.
2020-05-06 08:35:20 +00:00
index d1f82eff218..77adc64e30c 100644
Increase Light Queue Size Wiz mentioned that large WorldEdit operations cause light to run on main thread. The queue was small, set to 5.. this bumps it to 20 but makes it configurable per-world. The main risk of increasing this higher is during shutdown, some queued light updates may be lost because mojang did not flush the light engine on shutdown... The queue size only puts a cap on max loss, doesn't solve that problem. Don't touch this unless you know you have a problem and ok with the risk.
2020-04-09 01:36:10 +00:00
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
Load Spawn Chunks Asynchronously and Spiral Out Ensures absolute center is first in priority Speeds up server startup
2020-04-19 10:01:07 +00:00
@@ -637,7 +637,7 @@ public abstract class MinecraftServer extends IAsyncTaskHandlerReentrant<TickTas
Increase Light Queue Size Wiz mentioned that large WorldEdit operations cause light to run on main thread. The queue was small, set to 5.. this bumps it to 20 but makes it configurable per-world. The main risk of increasing this higher is during shutdown, some queued light updates may be lost because mojang did not flush the light engine on shutdown... The queue size only puts a cap on max loss, doesn't solve that problem. Don't touch this unless you know you have a problem and ok with the risk.
2020-04-09 01:36:10 +00:00
this.executeModerately();
// CraftBukkit end
worldloadlistener.b();
- chunkproviderserver.getLightEngine().a(5);
+ chunkproviderserver.getLightEngine().a(worldserver.paperConfig.lightQueueSize); // Paper - increase light queue size
// CraftBukkit start
this.forceTicks = false;
--
Anti Xray cleanup Undo the accidental renaming of a method in 0aad8bf Aikar wanted to rename DataPalette#getDataBits(T object) to getOrCreateIdFor in 0aad8bf but he also accidentally renamed ChunkPacketInfo#getDataBitsIndex(int chunkSectionIndex) to getOrCreateIdForIndex. Remove chunk-edge-mode and chunk loading entirely from Anti-Xray The chunk-edge-mode is broken since several versions. Loading chunk neighbors for chunk edge obfuscation isn't needed anymore. Unlike in previous versions, these are under normal circumstances already loaded at the time we need them (plugins for example can bypass this). Use the modified methods and constructors everywhere Anti-Xray provides support for the default nms methods and constructors, which where modified by Anti-Xray to avoid breaking stuff (plugins) which somehow uses these methods. However, the modified versions of those methods and constructors should be used where possible.
2020-05-06 08:35:20 +00:00
2.26.2
Increase Light Queue Size Wiz mentioned that large WorldEdit operations cause light to run on main thread. The queue was small, set to 5.. this bumps it to 20 but makes it configurable per-world. The main risk of increasing this higher is during shutdown, some queued light updates may be lost because mojang did not flush the light engine on shutdown... The queue size only puts a cap on max loss, doesn't solve that problem. Don't touch this unless you know you have a problem and ok with the risk.
2020-04-09 01:36:10 +00:00
Reference in a new issue Copy permalink